Messages in this thread | | | Date | Wed, 9 Oct 2013 02:20:36 +0100 | From | Al Viro <> | Subject | Re: [RFC][PATCH 10/13] make dump_emit() use vfs_write() instead of banging at ->f_op->write directly |
| |
On Wed, Oct 09, 2013 at 02:18:33AM +0100, Al Viro wrote:
> Point, but I would argue that we should yell very loud if we get 0 from > vfs_write() for non-zero size. I'm not sure if POSIX allows write(2) > to return that, but a lot of userland code won't be expecting that and > won't be able to cope...
PS: I agree that we should abort that loop if we get nr == 0, of course, but I believe that we should report the pathname of the offending file, at the very least.
| |