lkml.org 
[lkml]   [2013]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [xen] double fault: 0000 [#1] PREEMPT SMP DEBUG_PAGEALLOC
    On Tue, Oct 08, 2013 at 08:17:42PM +0800, Fengguang Wu wrote:
    > I find the above debug messages very helpful in locating the buggy
    > driver. How about enabling it whenever CONFIG_DEBUG_KOBJECT_RELEASE is
    > enabled? Something like
    >
    > #ifdef CONFIG_DEBUG_KOBJECT_RELEASE
    > - pr_debug("kobject: '%s' (%p): %s, parent %p (delayed)\n",
    > + printk(KERN_INFO "kobject: '%s' (%p): %s, parent %p (delayed)\n",
    > kobject_name(kobj), kobj, __func__, kobj->parent);
    >
    > pr_debug() won't be displayed by default, and it depends on
    > CONFIG_DYNAMIC_DEBUG.

    Please consider using pr_info() instead of printk(KERN_INFO - it's
    slightly less typing.

    I can see that being a useful change while we have these problematical
    instances to track down, but I do wonder whether it'll make the thing
    too noisy. Does anyone have other opinions on this point? Linus?
    Greg?


    \
     
     \ /
      Last update: 2013-10-09 00:21    [W:3.254 / U:0.536 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site