lkml.org 
[lkml]   [2013]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [RFC][PATCH 2/3] vfs: Add a function to lazily unmount all mounts from any dentry.
Miklos Szeredi <miklos@szeredi.hu> writes:

> On Fri, Oct 04, 2013 at 03:43:18PM -0700, Eric W. Biederman wrote:
>>
>> +void detach_mounts(struct dentry *dentry)
>> +{
>> + struct mount *mnt, *next;
>> + struct mountpoint *mp;
>> +
>> + namespace_lock();
>> + if (!d_mountpoint(dentry)) {
>> + namespace_unlock();
>> + return;
>> + }
>> + mp = new_mountpoint(dentry);
>> + if (IS_ERR(mp)) {
>> + return;
>> + }
>> + br_write_lock(&vfsmount_lock);
>> + list_for_each_entry_safe(mnt, next, &mp->m_list, mnt_mp_list) {
>
> I don't think list_for_each_entry_safe is actually safe enough here. Because
> propageted umounts will likely remove other mounts from the same mountpoint as
> well. Doing it with "while (!list_empty(&mp->m_list))" should be better, and
> AFAICS it will always make progress.

Thanks I will take a look. But on the surface that logic sounds
correct.

Eric


\
 
 \ /
  Last update: 2013-10-08 23:01    [W:0.156 / U:7.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site