Messages in this thread | | | Date | Tue, 8 Oct 2013 13:03:08 -0400 | From | Jason Cooper <> | Subject | Re: [PATCH v4] ARM: kirkwood: retain MAC address for DT ethernet |
| |
On Mon, Oct 07, 2013 at 10:25:11PM +0200, Sebastian Hesselbarth wrote: > Ethernet IP on Kirkwood SoCs loose their MAC address register content > if clock gated. To allow modular ethernet driver setups and gated clocks > also on non-DT capable bootloaders, we fixup port device nodes with no > valid MAC address property. This patch copies MAC address register > contents set up by bootloaders early, notably before ethernet clocks > are gated. While at it, also reorder call sequence in _dt_init. > > Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> > Reviewed-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> > Tested-by: Andrew Lunn <andrew@lunn.ch> > --- > Just to make sure they don't get lost this time: > Added Jason's and Ezequiel's Reviewed-by to honor their constant reviews, > and Andrew's last Tested-by because I know he will be testing again. > > Changelog: > v3->v4: > - drop clk_is_enabled (and dependency) due to possible abuse of the > new function; enable/disable clk instead, remove gated clock warning > (Suggested by Andrew Lunn, Uwe Kleine-Koenig, Mike Turquette) > - reduce FW_BUG to FW_INFO (Suggested by Andrew Lunn) > - proper cleanup of iomap, clk, nodes > v2->v3: > - make use of new public clk_is_enabled (adds dependency) > - add warning about gated clock && missing MAC property > (Suggested by Jason Gunthorpe) > v1->v2: > - check for gated clock before accessing eth registers > (Suggested by Andrew Lunn) > > Cc: Jason Cooper <jason@lakedaemon.net> > Cc: Andrew Lunn <andrew@lunn.ch> > Cc: Russell King <linux@arm.linux.org.uk> > Cc: Grant Likely <grant.likely@linaro.org> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Cc: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> > Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> > Cc: Mike Turquette <mturquette@linaro.org> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > arch/arm/mach-kirkwood/board-dt.c | 86 +++++++++++++++++++++++++++++++++++-- > 1 file changed, 83 insertions(+), 3 deletions(-)
Applied to mvebu/soc with Mike's Reviewed-by:
thx,
Jason.
| |