lkml.org 
[lkml]   [2013]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 31/50] tools/perf/build: Speed up auto-detection of features by adding a 'test-all' target

* Jiri Olsa <jolsa@redhat.com> wrote:

> On Mon, Oct 07, 2013 at 01:56:24PM +0200, Ingo Molnar wrote:
>
> SNIP
>
> > +
> > +#
> > +# Print the result of the feature test:
> > +#
> > +define feature_print_code
> > + ifeq ($(feature-$(1)), 1)
> > + MSG := $(shell printf '...%30s: [ \033[32mon\033[m ]' $(1))
> > + else
> > + MSG := $(shell printf '...%30s: [ \033[31mOFF\033[m ]' $(1))
> > + endif
> > + $(info $(MSG))
> > +endef
> > +
> > +$(foreach feat,$(FEATURE_TESTS) DUMMY,$(call feature_print,$(feat)))
> > +
> > +# newline at the end of the feature printouts:
> > +$(info )
> >
> > -ifeq ($(stackprotector-all), 1)
> > +ifeq ($(feature-stackprotector-all), 1)
> > CFLAGS += -fstack-protector-all
> > endif
>
> nit, belongs to:
> tools/perf/build: Split out feature check: 'stackprotector-all'

Indeed, fixed.

I also fixed the next hunk:

> ifndef NO_BIONIC
>+ $(feature_check,bionic)
> ifeq ($(feature-bionic), 1)
> BIONIC := 1

Which was misplaced as well.

Thanks,

Ingo


\
 
 \ /
  Last update: 2013-10-08 10:41    [W:0.083 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site