Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH 8/8] perf tools: Get current comm instead of last one | Date | Tue, 08 Oct 2013 10:56:49 +0900 |
| |
Hi Frederic,
On Wed, 2 Oct 2013 12:01:51 +0200, Frederic Weisbecker wrote: > On Thu, Sep 26, 2013 at 05:58:10PM +0900, Namhyung Kim wrote: >> From: Namhyung Kim <namhyung.kim@lge.com> >> >> At insert time, a hist entry should reference comm at the time >> otherwise it'll get the last comm anyway.
[SNIP]
>> --- a/tools/perf/util/comm.h >> +++ b/tools/perf/util/comm.h >> @@ -16,5 +16,6 @@ struct comm { >> void comm__free(struct comm *comm); >> struct comm *comm__new(const char *str, u64 timestamp); >> const char *comm__str(const struct comm *comm); >> +void comm__override(struct comm *self, const char *str, u64 timestamp); >> >> #endif /* __PERF_COMM_H */ >> diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c >> index a2d58e7abdcf..1aa97b012a09 100644 >> --- a/tools/perf/util/hist.c >> +++ b/tools/perf/util/hist.c >> @@ -412,6 +412,7 @@ struct hist_entry *__hists__add_mem_entry(struct hists *self, >> { >> struct hist_entry entry = { >> .thread = al->thread, >> + .comm = curr_comm(al->thread), > > So now that we have an accessor for that, it clashes a bit with existing names. > > I suggest we rename thread__comm_curr() -> thread__comm_str() > And rename curr_comm() -> thread__comm() > > Hmm?
Okay, I'll rename and resend.
Thanks, Namhyung
| |