lkml.org 
[lkml]   [2013]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC PATCH 00/50] tools/perf: Speed up the build system
Date
Ingo Molnar <mingo@kernel.org> writes:
>
> The series also includes a number of fixes and convenience features:
>
> - auto-detect the number of CPUs on the system and add the -j<cpus>
> option automatically

FWIW I would prefer if you not do that automatically, because:

- Often the optimal factor is not 1, but something like 1.5*CPUs
(but I'm not sure it's the same on all systems, probably depends on
the IO capacity and memory)
- It may use a lot of memory, so should be something controlled by the
user.
- Often it's useful to use a few threads less to avoid interactivity
problems on a workstation.
- With LTO there can be rare cases where you need to lower it to avoid
running out of memory.
- Kernel build users should be already trained to set that parameter
and it's not really a big burden.

The rest looks like a great improvement.

-Andi

--
ak@linux.intel.com -- Speaking for myself only


\
 
 \ /
  Last update: 2013-10-07 22:41    [W:1.444 / U:2.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site