lkml.org 
[lkml]   [2013]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 07/63] mm: numa: Sanitize task_numa_fault() callsites
On 10/07/2013 06:28 AM, Mel Gorman wrote:
> There are three callers of task_numa_fault():
>
> - do_huge_pmd_numa_page():
> Accounts against the current node, not the node where the
> page resides, unless we migrated, in which case it accounts
> against the node we migrated to.
>
> - do_numa_page():
> Accounts against the current node, not the node where the
> page resides, unless we migrated, in which case it accounts
> against the node we migrated to.
>
> - do_pmd_numa_page():
> Accounts not at all when the page isn't migrated, otherwise
> accounts against the node we migrated towards.
>
> This seems wrong to me; all three sites should have the same
> sementaics, furthermore we should accounts against where the page
> really is, we already know where the task is.
>
> So modify all three sites to always account; we did after all receive
> the fault; and always account to where the page is after migration,
> regardless of success.
>
> They all still differ on when they clear the PTE/PMD; ideally that
> would get sorted too.
>
> Cc: stable <stable@vger.kernel.org>
> Signed-off-by: Peter Zijlstra <peterz@infradead.org>
> Signed-off-by: Mel Gorman <mgorman@suse.de>

Reviewed-by: Rik van Riel <riel@redhat.com>

--
All rights reversed


\
 
 \ /
  Last update: 2013-10-07 16:41    [W:0.848 / U:5.852 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site