lkml.org 
[lkml]   [2013]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] checkpatch.pl: Check for the FSF mailing address
From
Date
On Sat, 2013-10-05 at 11:43 -0700, Josh Triplett wrote:
> Kernel maintainers reject new instances of the GPL boilerplate paragraph
> directing people to write to the FSF for a copy of the GPL, since the
> FSF has moved in the past and may do so again.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -1859,6 +1859,16 @@ sub process {
> $rpt_cleaners = 1;
> }
>
> +# Check for FSF mailing addresses.
> + if ($rawline =~ /You should have received a copy/ ||

There are over 9,000 of these in the tree.

> + $rawline =~ /write to the Free Software/ ||

Over 7,000

> + $rawline =~ /59 Temple Place/ ||

Over 3,500

> + $rawline =~ /51 Franklin Street/) {

Over 1,500

> + my $herevet = "$here\n" . cat_vet($rawline) . "\n";
> + ERROR("FSF_MAILING_ADDRESS",
> + "Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.\n" . $herevet)

Is this really a useful ERROR condition?
Maybe a CHK --strict test or a warning instead?



\
 
 \ /
  Last update: 2013-10-05 21:21    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog