Messages in this thread | | | Date | Fri, 4 Oct 2013 10:37:41 +0200 | From | Ingo Molnar <> | Subject | Re: [pchecks v2 2/2] percpu: Add preemption checks to __this_cpu ops |
| |
* Peter Zijlstra <peterz@infradead.org> wrote:
> > @@ -39,8 +39,8 @@ notrace unsigned int debug_smp_processor > > if (!printk_ratelimit()) > > goto out_enable; > > > > - printk(KERN_ERR "BUG: using smp_processor_id() in preemptible [%08x] " > > - "code: %s/%d\n", > > + printk(KERN_ERR "%s in preemptible [%08x] " > > + "code: %s/%d\n", what, > > preempt_count() - 1, current->comm, current->pid); > > I would argue for keeping the "BUG" string intact and in front of the > %s.
Definitely.
Thanks,
Ingo
| |