lkml.org 
[lkml]   [2013]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [pchecks v2 2/2] percpu: Add preemption checks to __this_cpu ops

* Peter Zijlstra <peterz@infradead.org> wrote:

> > @@ -39,8 +39,8 @@ notrace unsigned int debug_smp_processor
> > if (!printk_ratelimit())
> > goto out_enable;
> >
> > - printk(KERN_ERR "BUG: using smp_processor_id() in preemptible [%08x] "
> > - "code: %s/%d\n",
> > + printk(KERN_ERR "%s in preemptible [%08x] "
> > + "code: %s/%d\n", what,
> > preempt_count() - 1, current->comm, current->pid);
>
> I would argue for keeping the "BUG" string intact and in front of the
> %s.

Definitely.

Thanks,

Ingo


\
 
 \ /
  Last update: 2013-10-04 11:01    [W:0.198 / U:0.752 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site