lkml.org 
[lkml]   [2013]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] fs/ext4/namei.c: reducing contention on s_orphan_lock mmutex
On 10/03/2013 06:41 PM, Andreas Dilger wrote:

>> + struct inode *next_inode;
>
> Stack space in the kernel is not so abundant that all (or any?) of these
> should get their own local variable.
>
>>
>> - if (!EXT4_SB(sb)->s_journal)
>
> Same here.
>
>
> Cheers, Andreas

Thanks Andreas for the comments. On larger machines with processors with lots of register, with the compiler optimization I don't think it matters whether stack variables or repeated common expressions are used. On smaller machines with processors with limited number of registers, this will be a problem. I'll fix these on my rework.

Thanks,
Mak.




\
 
 \ /
  Last update: 2013-10-04 07:21    [W:0.068 / U:0.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site