Messages in this thread | | | Date | Thu, 03 Oct 2013 17:08:00 -0600 | From | Thavatchai Makphaibulchoke <> | Subject | Re: [PATCH 2/2] fs/ext4/namei.c: reducing contention on s_orphan_lock mmutex |
| |
On 10/03/2013 06:41 PM, Andreas Dilger wrote:
>> + struct inode *next_inode; > > Stack space in the kernel is not so abundant that all (or any?) of these > should get their own local variable. > >> >> - if (!EXT4_SB(sb)->s_journal) > > Same here. > > > Cheers, Andreas
Thanks Andreas for the comments. On larger machines with processors with lots of register, with the compiler optimization I don't think it matters whether stack variables or repeated common expressions are used. On smaller machines with processors with limited number of registers, this will be a problem. I'll fix these on my rework.
Thanks, Mak.
| |