Messages in this thread | | | From | Bjorn Helgaas <> | Date | Fri, 4 Oct 2013 09:55:59 -0600 | Subject | Re: [PATCH] PCI: Workaround missing pci_set_master in pci drivers |
| |
On Thu, Oct 3, 2013 at 5:35 PM, Yinghai Lu <yinghai@kernel.org> wrote: > On Thu, Oct 3, 2013 at 3:06 PM, Bjorn Helgaas <bhelgaas@google.com> wrote: >> On Sat, Sep 28, 2013 at 01:13:07PM -0700, Yinghai Lu wrote: >>> @@ -1156,8 +1156,14 @@ static void pci_enable_bridge(struct pci >>> >>> pci_enable_bridge(dev->bus->self); >>> >>> - if (pci_is_enabled(dev)) >>> + if (pci_is_enabled(dev)) { >>> + if (!dev->is_busmaster) { >>> + dev_warn(&dev->dev, "driver skip pci_set_master, fix it!\n"); >> >> I know this is already in Linus' tree, but if we're going to enable >> bus mastering here, what's the point of the warning? If somebody >> fixes the driver by adding a pci_set_master() call there, does that >> improve something? > > Help us to catch other offender and fix them.
What is improved by doing it in the driver instead of here?
| |