Messages in this thread | | | Date | Thu, 31 Oct 2013 18:03:35 -0700 | From | David Cohen <> | Subject | Re: [PATCH V2] checkpatch: Improve "return is not a function" test |
| |
On 10/31/2013 04:12 PM, Joe Perches wrote: > Find a few more cases where parentheses are used around > the value of a return statement. > > This now uses the "$balanced_parens" test and also makes > the test depend on perl v5.10 and higher. > > This now finds return with parenthesis uses the old code > did not find like: > > ERROR: return is not a function, parentheses are not required > #211: FILE: arch/m68k/include/asm/sun3xflop.h:211: > + return ((error == 0) ? 0 : -1); > > Signed-off-by: Joe Perches <joe@perches.com>
It catches the previous false-negative I had.
Acked-by: David Cohen <david.a.cohen@linux.intel.com>
| |