lkml.org 
[lkml]   [2013]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf tools: Remove cast of non-varadic function to varadic
Hi Michael,

On Thu, Oct 31, 2013 at 07:50:25PM +0000, Michael Hudson-Doyle wrote:
> 4fb71074a570 (perf ui/hist: Consolidate hpp helpers) introduced a cast of
> percent_color_snprintf to a function pointer type with varargs. Change
> percent_color_snprintf to be varadic and remove the cast.

nit: s/varadic/variadic/

> The symptom of this was all percentages being reported as 0.00% in perf
> report --stdio output on armhf.

Acked-by: Will Deacon <will.deacon@arm.com>

Probably worth CCing stable too.

Will


\
 
 \ /
  Last update: 2013-10-31 21:21    [W:1.216 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site