Messages in this thread | | | Date | Thu, 31 Oct 2013 20:06:16 +0000 | From | Will Deacon <> | Subject | Re: [PATCH] perf tools: Remove cast of non-varadic function to varadic |
| |
Hi Michael,
On Thu, Oct 31, 2013 at 07:50:25PM +0000, Michael Hudson-Doyle wrote: > 4fb71074a570 (perf ui/hist: Consolidate hpp helpers) introduced a cast of > percent_color_snprintf to a function pointer type with varargs. Change > percent_color_snprintf to be varadic and remove the cast.
nit: s/varadic/variadic/
> The symptom of this was all percentages being reported as 0.00% in perf > report --stdio output on armhf.
Acked-by: Will Deacon <will.deacon@arm.com>
Probably worth CCing stable too.
Will
| |