lkml.org 
[lkml]   [2013]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 3/4] perf/x86: add Intel RAPL PMU support
    On Thu, Oct 31, 2013 at 03:59:41PM +0100, Stephane Eranian wrote:
    > +/*
    > + * we compute in 0.23 nJ increments regardless of MSR

    We don't in fact use 0.23 nJ, we use 2^-32 J.

    > + */
    > +EVENT_ATTR_STR(energy-cores.scale, rapl_cores_scale, "2.3e-10");
    > +EVENT_ATTR_STR(energy-pkg.scale, rapl_pkg_scale, "2.3e-10");
    > +EVENT_ATTR_STR(energy-ram.scale, rapl_ram_scale, "2.3e-10");

    Am I weird for proposing we use:

    "2.3283064365386962890625e-10"

    instead? Its not like anybody needs to go type this by hand.


    \
     
     \ /
      Last update: 2013-10-31 16:41    [W:3.889 / U:0.300 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site