Messages in this thread | | | Date | Thu, 31 Oct 2013 12:32:01 +0200 | From | Tomi Valkeinen <> | Subject | Re: [PATCH v3] omapdss: Add new panel driver for Topolly td028ttec1 LCD. |
| |
On 2013-10-30 00:25, Marek Belisko wrote: > Signed-off-by: Marek Belisko <marek@goldelico.com> > Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> > --- > changes from v2: > - move tx_buf from driver data to functions where it's used > - update write functions names (to reflect how many bytes are transferred) > - update delays from 1s to 1ms (probably typo) > - remove unnecessary 90ms sleep (tested and works fine) > - disable dpi output after disable panel > > changes from v1: > - reworked to be spi driver instead platform with custom spi bitbang > this configuration was tested with spi_gpio bitbang driver on gta04 board > and works fine (thanks Tomi and Lars-Peter for comments) > - address previous comments > > drivers/video/omap2/displays-new/Kconfig | 6 + > drivers/video/omap2/displays-new/Makefile | 1 + > .../omap2/displays-new/panel-tpo-td028ttec1.c | 480 +++++++++++++++++++++ > include/video/omap-panel-data.h | 13 + > 4 files changed, 500 insertions(+) > create mode 100644 drivers/video/omap2/displays-new/panel-tpo-td028ttec1.c
Sparse gave these warnings:
drivers/video/omap2/displays-new/panel-tpo-td028ttec1.c:67:5: warning: symbol 'jbt_ret_write_0' was not declared. Should it be static? drivers/video/omap2/displays-new/panel-tpo-td028ttec1.c:81:5: warning: symbol 'jbt_reg_write_1' was not declared. Should it be static? drivers/video/omap2/displays-new/panel-tpo-td028ttec1.c:97:5: warning: symbol 'jbt_reg_write_2' was not declared. Should it be static?
I fixed them and queued the patch for 3.13.
Tomi
[unhandled content-type:application/pgp-signature] | |