lkml.org 
[lkml]   [2013]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH-next v3] kernel/system_certificate.S: use real contents instead of macro GLOBAL()
On 10/30/2013 08:57 PM, David Howells wrote:
> Chen Gang <gang.chen@asianux.com> wrote:
>
>> If a macro is only used within 2 times, and also its contents are
>> within 2 lines, recommend to expand it to shrink code line.
>>
>> For our case, the macro is not portable either: some architectures'
>> assembler may use another character to mark newline in a macro (e.g.
>> '`' for arc), which will cause issue.
>>
>> If still want to use macro and let it portable enough, it will also
>> need include additional header file (e.g "#include <linux/linkage.h>",
>> although it also need be fixed).
>
> Fine by me.
>
> Applied.
>
>

Thanks.
--
Chen Gang


\
 
 \ /
  Last update: 2013-10-31 02:21    [W:0.072 / U:2.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site