lkml.org 
[lkml]   [2013]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v4)
On 31/10/13 04:35, Greg KH wrote:

> On Wed, Oct 30, 2013 at 10:32:58AM +0100, Frank Haverkamp wrote:
>> +if GENWQE
>> +
>> +config GENWQE_DEVNAME
>> + string "Name for sysfs and device nodes"
>> + default "genwqe"
>> + help
>> + Select alternate name for sysfs and device nodes.
>
> Don't let the user pick this, it's up to the driver to set this once and
> then live with it.
>
> And, from what I can tell in the driver, this help text is wrong (there
> are no device nodes with this name in it, right?)


The indentation is also messed up here. Kconfig should use hard tabs, with
two additional spaces for the help text. This has mixed tabs and spaces
between lines.

~Ryan




\
 
 \ /
  Last update: 2013-10-30 22:21    [W:0.092 / U:2.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site