Messages in this thread Patch in this message | | | From | Yann Droneaud <> | Subject | [PATCH v4 6/7] events: use get_unused_fd_flags(0) instead of get_unused_fd() | Date | Wed, 30 Oct 2013 20:47:46 +0100 |
| |
Macro get_unused_fd() is used to allocate a file descriptor with default flags. Those default flags (0) can be "unsafe": O_CLOEXEC must be used by default to not leak file descriptor across exec().
Instead of macro get_unused_fd(), functions anon_inode_getfd() or get_unused_fd_flags() should be used with flags given by userspace. If not possible, flags should be set to O_CLOEXEC to provide userspace with a default safe behavor.
In a further patch, get_unused_fd() will be removed so that new code start using anon_inode_getfd() or get_unused_fd_flags() with correct flags.
This patch replaces calls to get_unused_fd() with equivalent call to get_unused_fd_flags(0) to preserve current behavor for existing code.
The hard coded flag value (0) should be reviewed on a per-subsystem basis, and, if possible, set to O_CLOEXEC.
Signed-off-by: Yann Droneaud <ydroneaud@opteya.com> Link: http://lkml.kernel.org/r/cover.1383121137.git.ydroneaud@opteya.com --- kernel/events/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c index 354a59c..142d13c 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -6970,7 +6970,7 @@ SYSCALL_DEFINE5(perf_event_open, if ((flags & PERF_FLAG_PID_CGROUP) && (pid == -1 || cpu == -1)) return -EINVAL; - event_fd = get_unused_fd(); + event_fd = get_unused_fd_flags(0); if (event_fd < 0) return event_fd; -- 1.8.3.1
| |