lkml.org 
[lkml]   [2013]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 3/3] hwmon: (lm90) use enums for the indexes of temp8 and temp11
Hi Wei,

On Wed, 7 Aug 2013 14:18:26 +0800, Wei Ni wrote:
> Using enums for the indexes and nrs of temp8 and temp11.
> This make the code much more readable.
>
> Signed-off-by: Wei Ni <wni@nvidia.com>
> ---
> drivers/hwmon/lm90.c | 154 +++++++++++++++++++++++++++++---------------------
> 1 file changed, 90 insertions(+), 64 deletions(-)
> (...)

Looks much better except for one minor detail:

> +/*
> + * TEMP11 register index
> + */
> +enum lm90_temp11_reg_index {
> + REMOTE_TEMP = 0,
> + REMOTE_LOW,
> + REMOTE_HIGH,
> + REMOTE_OFFSET, /* except max6646, max6657/58/59,
> + * and max6695/96
> + */

This comment fits on a single line now.

> + LOCAL_TEMP,
> + REMOTE2_TEMP, /* max6695/96 only */
> + REMOTE2_LOW, /* max6695/96 only */
> + REMOTE2_HIGH, /* max6695/96 only */
> + TEMP11_REG_NUM
> +};

Other than that, it's OK, and I think I'll apply it after all.

--
Jean Delvare


\
 
 \ /
  Last update: 2013-10-30 17:41    [W:0.104 / U:0.976 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site