lkml.org 
[lkml]   [2013]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH rebased] sysfs: return correct error code on unimplemented mmap()
Greg,

On 10/30/13 14:08, Vladimir Zapolskiy wrote:
> Both POSIX.1-2008 and Linux Programmer's Manual have a dedicated return
> error code for a case, when a file doesn't support mmap(), it's ENODEV.
>
> This change replaces overloaded EINVAL with ENODEV in a situation
> described above for sysfs binary files.
>
> Signed-off-by: Vladimir Zapolskiy<vladimir_zapolskiy@mentor.com>
> Cc: Greg Kroah-Hartman<gregkh@linuxfoundation.org>
> ---
> fs/sysfs/file.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c
> index 0d7368d4..382db3c 100644
> --- a/fs/sysfs/file.c
> +++ b/fs/sysfs/file.c
> @@ -477,7 +477,6 @@ static int sysfs_bin_mmap(struct file *file, struct vm_area_struct *vma)
> if (!sysfs_get_active(of->sd))
> goto out_unlock;
>
> - rc = -EINVAL;
> if (!battr->mmap)
> goto out_put;
>

as you asked the patch is rebased on top of linux-next, if you encounter
any problems related to the change, please let me know.

Thanks,
Vladimir


\
 
 \ /
  Last update: 2013-10-30 16:21    [W:0.033 / U:12.748 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site