lkml.org 
[lkml]   [2013]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [char-misc-next 1/8] mei: debugfs: validate dev is not null
On Wed, Oct 30, 2013 at 07:16:07AM +0000, Winkler, Tomas wrote:
> >
> > On Mon, Oct 21, 2013 at 10:05:36PM +0300, Tomas Winkler wrote:
> > > make static analyzer happy
> >
> > That's a stupid analyzer.
> >
> > Sorry, this case can never be true, so don't check for it. Fix your
> > analyzer.
> >
> > > and validate dev argument before dereferencing
> >
> > Again, no need to do so, it's always set properly.
> >
> > sorry, I can't take this.
>
> Fair enough, I didn't like that patch myself now I have other confirmation that this is stupid.

This is about the 10th time I have gotten patches that are somehow being
_forced_ by Intel developers to submit, and require me to say they are
stupid and wrong and push back on.

Someone needs to go stop that Intel code analyzer and push back on them
directly, don't rely on me being the one to do this, it only makes me
grumpy and mad when you all make me do your job on this :(

greg k-h


\
 
 \ /
  Last update: 2013-10-30 14:41    [W:0.058 / U:12.820 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site