Messages in this thread | | | Date | Thu, 3 Oct 2013 16:26:10 -0400 | From | Neil Horman <> | Subject | Re: [PATCH] iommu: Remove stack trace from broken irq remapping warning |
| |
On Thu, Oct 03, 2013 at 10:08:24PM +0200, Joerg Roedel wrote: > On Thu, Oct 03, 2013 at 01:21:42PM -0400, Neil Horman wrote: > > On Fri, Sep 27, 2013 at 12:53:35PM -0400, Neil Horman wrote: > > > The warning for the irq remapping broken check in intel_irq_remapping.c is > > > pretty pointless. We need the warning, but we know where its comming from, the > > > stack trace will always be the same, and it needlessly triggers things like > > > Abrt. This changes the warning to just print a text warning about BIOS being > > > broken, without the stack trace, then sets the appropriate taint bit. Since we > > > automatically disable irq remapping, theres no need to contiue making Abrt jump > > > at this problem > > > > > > Signed-off-by: Neil Horman <nhorman@tuxdriver.com> > > > CC: Joerg Roedel <joro@8bytes.org> > > > CC: Bjorn Helgaas <bhelgaas@google.com> > > > CC: Andy Lutomirski <luto@amacapital.net> > > > CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > > > CC: Sebastian Andrzej Siewior <sebastian@breakpoint.cc> > > > > Ping Bjorn, Jeorg, any thoughts here? > > Yes, the patch is doing the right thing. I have it already on my list > and will merge it soon. > Awesome, thanks guys. Regarding the taint, I'll propose something for that early next week.
Regards Neil
> > Joerg > > >
| |