lkml.org 
[lkml]   [2013]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging:iio: fix wrong usage of dev_set_name()
On 10/03/2013 04:57 PM, Sangjung Woo wrote:
> The second parameter of dev_set_name() is format string. In order to
> avoid any potential accidents such as segmentation fault, basic format
> parameter "%s" should be used in this case.

Since "iio_evgen" is a constant string there is really no need for this.

>
> Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
> ---
> drivers/staging/iio/iio_dummy_evgen.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/iio_dummy_evgen.c b/drivers/staging/iio/iio_dummy_evgen.c
> index 132d278..2c06d16 100644
> --- a/drivers/staging/iio/iio_dummy_evgen.c
> +++ b/drivers/staging/iio/iio_dummy_evgen.c
> @@ -205,7 +205,7 @@ static __init int iio_dummy_evgen_init(void)
> if (ret < 0)
> return ret;
> device_initialize(&iio_evgen_dev);
> - dev_set_name(&iio_evgen_dev, "iio_evgen");
> + dev_set_name(&iio_evgen_dev, "%s", "iio_evgen");
> return device_add(&iio_evgen_dev);
> }
> module_init(iio_dummy_evgen_init);
>



\
 
 \ /
  Last update: 2013-10-03 20:41    [W:0.048 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site