lkml.org 
[lkml]   [2013]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 11/11] pinctrl: plgpio: Remove redundant of_match_ptr
From
On 3 October 2013 10:07, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 28 September 2013 17:38, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>> The data structure of_match_ptr() protects is always compiled in.
>
> of_match_ptr() isn't a data structure..

Yes you are right. of_match_ptr() is a macro. The data structure here
refers to its argument and not of_match_ptr() itself.

>And also what does "protects" mean here?

It just means that of_match_ptr() avoids an undefined reference error
had CONFIG_OF been used around the data structures definition by
making the pointer NULL.

>
>> Hence of_match_ptr() is not needed.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> Cc: Viresh Kumar <viresh.kumar@linaro.org>
>> ---
>> drivers/pinctrl/spear/pinctrl-plgpio.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/pinctrl/spear/pinctrl-plgpio.c b/drivers/pinctrl/spear/pinctrl-plgpio.c
>> index 0a7f0bdb..ff2940e 100644
>> --- a/drivers/pinctrl/spear/pinctrl-plgpio.c
>> +++ b/drivers/pinctrl/spear/pinctrl-plgpio.c
>> @@ -735,7 +735,7 @@ static struct platform_driver plgpio_driver = {
>> .owner = THIS_MODULE,
>> .name = "spear-plgpio",
>> .pm = &plgpio_dev_pm_ops,
>> - .of_match_table = of_match_ptr(plgpio_of_match),
>> + .of_match_table = plgpio_of_match,
>> },
>> };
>
> Patch is okay otherwise.

Hope to have your ack on this :)
Thanks for reviewing.

--
With warm regards,
Sachin


\
 
 \ /
  Last update: 2013-10-03 09:21    [W:0.956 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site