lkml.org 
[lkml]   [2013]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 02/15] KVM: MMU: properly check last spte in fast_page_fault()
From
Date

On Oct 1, 2013, at 5:23 AM, Marcelo Tosatti <mtosatti@redhat.com> wrote:

>>
>
> Unrelated to this patch:
>
> If vcpu->mode = OUTSIDE_GUEST_MODE, no IPI is sent
> by kvm_flush_remote_tlbs.

Yes.

>
> So how is this supposed to work again?
>
> /*
> * Wait for all vcpus to exit guest mode and/or lockless shadow
> * page table walks.
> */

On the lockless walking path, we change the vcpu->mode to
READING_SHADOW_PAGE_TABLES, so that IPI is needed.
Or i missed your question?


> kvm_flush_remote_tlbs(kvm);
>
> Patch looks fine.

Thank you, Marcelo!



\
 
 \ /
  Last update: 2013-10-03 08:41    [W:0.115 / U:0.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site