lkml.org 
[lkml]   [2013]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] dynamic_debug: add wildcard support to filter files/functions/modules
From
Hello, Joe,

Thanks for your comments. I will update the patch. And now I am trying
to remove all the two goto statements. Agree with you, we can use a
while statement instead.

I will send you the new patch for you to review when it's done.


2013/10/29 Joe Perches <joe@perches.com>
>
> On Mon, 2013-10-28 at 23:29 +0800, Du, Changbin wrote:
> > From: "Du, Changbin" <changbin.du@gmail.com>
>
> trivial notes:
>
> > This patch add wildcard '*'(matches zero or more characters) and '?'
> > (matches one character) support when qurying debug flags.
>
> > diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
> []
> > @@ -127,6 +127,41 @@ static void vpr_info_dq(const struct ddebug_query *query, const char *msg)
> > query->first_lineno, query->last_lineno);
> > }
> >
> > +/* check if the string matches given pattern which includes wildcards */
> > +static int match_pattern(const char *pattern, const char *string)
>
> bool match_pattern
>
> > +{
> > + const char *s, *p;
> > + int star = 0;
>
> bool star = false;
>
> > +
> > +loop:
> > + for (s = string, p = pattern; *s; ++s, ++p) {
> > + switch (*p) {
> > + case '?':
> > + break;
> > + case '*':
> > + star = 1;
> > + string = s;
> > + pattern = p;
> > + if (!*++pattern)
> > + return 1;
> > + goto loop;
> > + default:
> > + if (*s != *p)
> > + goto star_check;
>
> star = false;
>
> > + break;
> > + }
> > + }
> > + if (*p == '*')
> > + ++p;
> > + return (!*p);
>
> Don't need parentheses.
>
> > +
> > +star_check:
> > + if (!star)
> > + return 0;
> > + string++;
> > + goto loop;
> > +}
>
> The star_check: label block seems like it'd be
> better in the switch case as it's only used once.
>
> Maybe the thing would be more readable with a
> while loop
>


\
 
 \ /
  Last update: 2013-10-29 09:21    [W:0.310 / U:0.952 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site