lkml.org 
[lkml]   [2013]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] watchdog: Get rid of MODULE_ALIAS_MISCDEV statements
Hi Jean,

> I just can't find any value in MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR)
> and MODULE_ALIAS_MISCDEV(TEMP_MINOR) statements.
>
> Either the device is enumerated and the driver already has a module
> alias (e.g. PCI, USB etc.) that will get the right driver loaded
> automatically.
>
> Or the device is not enumerated and loading its driver will lead to
> more or less intrusive hardware poking. Such hardware poking should be
> limited to a bare minimum, so the user should really decide which
> drivers should be tried and in what order. Trying them all in
> arbitrary order can't do any good.
>
> On top of that, loading that many drivers at once bloats the kernel
> log. Also many drivers will stay loaded afterward, bloating the output
> of "lsmod" and wasting memory. Some modules (cs5535_mfgpt which gets
> loaded as a dependency) can't even be unloaded!
>
> If defining char-major-10-130 is needed then it should happen in
> user-space.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Wim Van Sebroeck <wim@iguana.be>
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> Cc: Mike Frysinger <vapier.adi@gmail.com>
> Cc: Wan ZongShun <mcuos.com@gmail.com>
> Cc: Ben Dooks <ben-linux@fluff.org>
> Cc: Kukjin Kim <kgene.kim@samsung.com>
> Cc: Zwane Mwaikambo <zwane@arm.linux.org.uk>
> Cc: Jim Cromie <jim.cromie@gmail.com>
> Cc: Guenter Roeck <linux@roeck-us.net>

This patch has been added to linux-watchdog-next.
I also added the removal part for the new rt2880_wdt.c driver to it.

Kind regards,
Wim.



\
 
 \ /
  Last update: 2013-10-29 09:21    [W:0.029 / U:4.884 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site