Messages in this thread | | | Date | Tue, 29 Oct 2013 19:58:55 +0100 | From | Levente Kurusa <> | Subject | Re: [PATCH trivial] ata: libata-eh: Remove unnecessary snprintf arithmetic |
| |
2013-10-29 19:53 keltezéssel, Tejun Heo írta: > Hello, > > On Tue, Oct 29, 2013 at 07:38:38PM +0100, Levente Kurusa wrote: >> Remove an unnecessary arithmetic operation from a call to snprintf, because >> the size parameter of snprintf includes the trailing null byte. >> >> Signed-off-by: Levente Kurusa <levex@linux.com> >> --- >> diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c >> index f9476fb..b7c4146 100644 >> --- a/drivers/ata/libata-eh.c >> +++ b/drivers/ata/libata-eh.c >> @@ -2427,7 +2434,7 @@ static void ata_eh_link_report(struct ata_link *link) >> >> memset(tries_buf, 0, sizeof(tries_buf)); > > While at it, can you please remove the above and just initialize the > buffer to "" on definition?
Sure, sending v2 in a moment.
-- Regards, Levente Kurusa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |