Messages in this thread | | | Date | Tue, 29 Oct 2013 14:53:02 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH trivial] ata: libata-eh: Remove unnecessary snprintf arithmetic |
| |
Hello,
On Tue, Oct 29, 2013 at 07:38:38PM +0100, Levente Kurusa wrote: > Remove an unnecessary arithmetic operation from a call to snprintf, because > the size parameter of snprintf includes the trailing null byte. > > Signed-off-by: Levente Kurusa <levex@linux.com> > --- > diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c > index f9476fb..b7c4146 100644 > --- a/drivers/ata/libata-eh.c > +++ b/drivers/ata/libata-eh.c > @@ -2427,7 +2434,7 @@ static void ata_eh_link_report(struct ata_link *link) > > memset(tries_buf, 0, sizeof(tries_buf));
While at it, can you please remove the above and just initialize the buffer to "" on definition?
Thanks.
-- tejun
| |