lkml.org 
[lkml]   [2013]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: READ/WRITE definitions in drivers/spi/spi-omap-100k.c
From
On Thu, Oct 24, 2013 at 2:46 PM, Tejun Heo <tj@kernel.org> wrote:

> Hey, guys.
>
> I was modifying includes in a core header file and got duplicate macro
> definition warnings on READ / WRITE in drivers/spi/spi-omap-100k.c.
> Apparently that driver defines READ / WRITE as macros and assigns the
> opposite values to them from the usual READ / WRITE constants defined
> in include/linux/fs.h.
>
> I just skimmed through it and there doesn't seem to be any user of the
> macros. Can we *please* remove these? Please note that READ / WRITE
> defined in include/linux/fs.h is something which is widely used
> throughout the kernel and there are multiple interfaces which take
> those constants. Re-defining them in the other way around in a driver
> file can lead to subtle issues and just is a bad idea. In general,
> refraining from using generic symbols without any qualitification in
> low level drivers would be nice.

That seems like a good idea, but we better poke the people who wrote
the code and the SPI maintainer :-)

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2013-10-29 15:21    [W:0.088 / U:7.856 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site