lkml.org 
[lkml]   [2013]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] genirq: Avoid NULL OOPS in irq handling
On Sat, 28 Sep 2013, Huacai Chen wrote:

> Some devices (e.g. serial port) setup irq handler at dev open and free
> it at dev close. So, sometimes there is no irqaction for a specific
> irq. But some buggy devices may send irqs at any time. This patch avoid
> the NULL OOPS when irqaction isn't registered.

All callers except the real per cpu interrupts are checking whether
there is a valid action before calling. And serial ports are not
routed to real per cpu interrupts. Can you provide more detailed
information about the problem you are trying to solve please?

Thanks,

tglx

> Signed-off-by: Huacai Chen <chenhc@lemote.com>
> ---
> kernel/irq/handle.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c
> index 131ca17..1c78e69 100644
> --- a/kernel/irq/handle.c
> +++ b/kernel/irq/handle.c
> @@ -135,6 +135,9 @@ handle_irq_event_percpu(struct irq_desc *desc, struct irqaction *action)
> irqreturn_t retval = IRQ_NONE;
> unsigned int flags = 0, irq = desc->irq_data.irq;
>
> + if (!action)
> + goto out;
> +
> do {
> irqreturn_t res;
>
> @@ -174,6 +177,7 @@ handle_irq_event_percpu(struct irq_desc *desc, struct irqaction *action)
>
> add_interrupt_randomness(irq, flags);
>
> +out:
> if (!noirqdebug)
> note_interrupt(irq, desc, retval);
> return retval;
> --
> 1.7.7.3
>
>


\
 
 \ /
  Last update: 2013-10-29 14:41    [W:0.060 / U:11.568 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site