lkml.org 
[lkml]   [2013]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] arch: use ASM_NL instead of ';' for assembler new line character in the macro
    On 10/29/2013 06:39 PM, David Howells wrote:
    > Chen Gang <gang.chen@asianux.com> wrote:
    >
    >>> > > And you also need to fix kernel/modsign_certificate.S as part of same patchset as
    >>> > > that is where the problem started in first place.
    >>> > >
    >> >
    >> > Hmm... can that be another patch?
    >> >
    >> > For "kernel/modsign_certificate.S", I recommend to expand the macro
    >> > which will shrink code line, either need not include additional header
    >> > file, I feel that will be simpler for both code reader and writers.
    > I recommend leaving that file alone. That gets moved to a .S file in patches
    > queued in the security tree.

    Excuse me, I am not quite familiar with our version merging, I guess
    your meaning is "this file will be removed, and the related contents
    will be in another .S file, so we need not fix it within this file".

    If what I guess is correct, I support your recommendation (and if what I
    guess is incorrect, please let me know, thanks). :-)

    BTW: I still use next-20130927 tree for it, and another next-tree branch
    which is next-20131025 do not have this file.


    Thanks.
    --
    Chen Gang


    \
     
     \ /
      Last update: 2013-10-29 13:21    [W:2.343 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site