Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH] arch: use ASM_NL instead of ';' for assembler new line character in the macro | Date | Tue, 29 Oct 2013 10:39:29 +0000 |
| |
Chen Gang <gang.chen@asianux.com> wrote:
> > And you also need to fix kernel/modsign_certificate.S as part of same patchset as > > that is where the problem started in first place. > > > > Hmm... can that be another patch? > > For "kernel/modsign_certificate.S", I recommend to expand the macro > which will shrink code line, either need not include additional header > file, I feel that will be simpler for both code reader and writers.
I recommend leaving that file alone. That gets moved to a .S file in patches queued in the security tree.
David
| |