lkml.org 
[lkml]   [2013]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/6] perf timechart: add support for -P and -T in timechart recording
> It should be ARRAY_SIZE(old_power_args).
Thanks :-)

> Do we really need to separate the option and usage for record? AFAICS
> it does exactly same thing..
Yes, we do. Some options which are defined for timechart are undefined
for record (like -i, -o, etc), so we want to get an error in case of wrong
options.

And we separate usage, because it's different in timechart:
"perf timechart [<options>] {record}",

and record:
"perf timechart record [<options>]",

We may share usage, but we need it to be something (confusing?) like:
"perf timechart [<options>] {record [<options>]}",


\
 
 \ /
  Last update: 2013-10-29 11:21    [W:0.066 / U:3.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site