lkml.org 
[lkml]   [2013]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/6] ARM: Add Krait L2 accessor functions
On Tue, Oct 29, 2013 at 01:21:57AM +0000, Stephen Boyd wrote:
> On 10/28/13 18:19, Mark Rutland wrote:
> > On Tue, Oct 29, 2013 at 12:31:27AM +0000, Stephen Boyd wrote:
> >> Qualcomm's Krait CPUs have a handful of L2 cache controller
> >> registers that live behind a cp15 based indirection register.
> >> First you program the indirection register (l2cpselr) to point
> >> the L2 'window' register (l2cpdr) at what you want to read/write.
> >> Then you read/write the 'window' register to do what you want.
> >> The l2cpselr register is not banked per-cpu so we must lock
> >> around accesses to it to prevent other CPUs from re-pointing
> >> l2cpdr underneath us.
> >>
> >> Cc: Russell King <linux@arm.linux.org.uk>
> >> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> >> ---
> >> arch/arm/common/Kconfig | 3 ++
> >> arch/arm/common/Makefile | 1 +
> >> arch/arm/common/krait-l2-accessors.c | 52 +++++++++++++++++++++++++++++++
> >> arch/arm/include/asm/krait-l2-accessors.h | 20 ++++++++++++
> >> 4 files changed, 76 insertions(+)
> >> create mode 100644 arch/arm/common/krait-l2-accessors.c
> >> create mode 100644 arch/arm/include/asm/krait-l2-accessors.h
> > [...]
> >
> >> +void set_l2_indirect_reg(u32 addr, u32 val)
> >> +{
> >> + unsigned long flags;
> >> +
> >> + raw_spin_lock_irqsave(&krait_l2_lock, flags);
> >> +
> >> + asm volatile ("mcr p15, 3, %0, c15, c0, 6" : : "r" (addr));
> >> + isb();
> >> + asm volatile ("mcr p15, 3, %0, c15, c0, 7" : : "r" (val));
> >> + isb();
> >> +
> >> + raw_spin_unlock_irqrestore(&krait_l2_lock, flags);
> >> +}
> >> +EXPORT_SYMBOL(set_l2_indirect_reg);
> > It might be worth commmenting inline as to what register each of these is
> > accessing. Inevitably the commit message will become harder to find and
> > associate with the code over time.
> >
> > Similarly for get_l2_indirect_reg.
>
> Do you mean with the "@" syntax in the assembly? The 80-character limit
> is out to get me.

I probably didn't mean inline :)

How about a block comment above the first asm block like:

/*
* Select the L2 window by poking l2cpselr, then write to the window via
* l2cpdr.
*/

Thanks,
Mark.


\
 
 \ /
  Last update: 2013-10-29 03:01    [W:0.093 / U:3.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site