lkml.org 
[lkml]   [2013]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/2] dma: mv_xor: Use high_base mmio where appropriate
From
[ adding dmaengine ]

On Mon, Oct 28, 2013 at 3:54 PM, Ezequiel Garcia
<ezequiel.garcia@free-electrons.com> wrote:
> Despite requesting two memory resources, called 'base' and 'high_base', the
> driver uses explicitly only the former. The latter is being used implicitly
> by addressing at offset +0x200, which in practice accesses high_base.
>
> Instead of relying in such trick, let's define the registers with the
> offset from high_base, and use high_base explicitly where appropriate.
>
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> ---
> drivers/dma/mv_xor.c | 3 ++-
> drivers/dma/mv_xor.h | 25 +++++++++++++------------
> 2 files changed, 15 insertions(+), 13 deletions(-)

Since it's unused I'd prefer a patch that just deletes xor_high_base.

--
Dan


\
 
 \ /
  Last update: 2013-10-29 01:21    [W:0.074 / U:0.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site