Messages in this thread | | | Date | Mon, 28 Oct 2013 07:23:22 +0000 | From | "Jan Beulich" <> | Subject | Re: [PATCH 1/2] x86: unify copy_from_user() size checking |
| |
>>> On 26.10.13 at 12:31, Ingo Molnar <mingo@kernel.org> wrote: > * Jan Beulich <JBeulich@suse.com> wrote: >> I'd like to point out though that with __compiletime_object_size() >> being restricted to gcc before 4.6, the whole construct is going to >> become more and more pointless going forward. I would question >> however that commit 2fb0815c9ee6b9ac50e15dd8360ec76d9fa46a2 ("gcc4: >> disable __compiletime_object_size for GCC 4.6+") was really necessary, >> and instead this should have been dealt with as is done here from the >> beginning. > > Can we now revert 2fb0815c9ee6?
Afaict yes, but I certainly didn't test with all possible gcc versions. So minimally everyone involved in getting that change in would be good to be in agreement.
Jan
| |