lkml.org 
[lkml]   [2013]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] mmc: arasan: Add driver for Arasan SDHCI
On 10/15/2013 02:08 PM, Soren Brinkmann wrote:
> Add a driver for Arasan's SDHCI controller core.
>
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> ---
> .../devicetree/bindings/mmc/arasan,sdhci.txt | 23 +++
> MAINTAINERS | 1 +
> drivers/mmc/host/Kconfig | 12 ++
> drivers/mmc/host/Makefile | 1 +
> drivers/mmc/host/sdhci-of-arasan.c | 224 +++++++++++++++++++++
> 5 files changed, 261 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> create mode 100644 drivers/mmc/host/sdhci-of-arasan.c
>
> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> new file mode 100644
> index 000000000000..20f0fc25e270
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> @@ -0,0 +1,23 @@
> +Device Tree Bindings for the Arasan SDCHI Controller
> +
> + The bindings follow the mmc[1] and the clock bindings[2]. Only deviations are
> + documented here.
> +
> + [1] Documentation/devicetree/bindings/mmc/mmc.txt
> + [2] Documentation/devicetree/bindings/clock/clock-bindings.txt
> +
> +Required Properties:
> + - compatible: Compatibility string. Must be 'arasan,sdhci'

This string is a bit non-specific. Vendor IP typically has configurable
options, different revs of IP with fixes/differences, and the
possibility of integration wierdness or bugs. So it is better to be as
specific as possible in case the kernel needs to know exactly what
version of h/w this is.

Rob



\
 
 \ /
  Last update: 2013-10-29 01:01    [W:0.087 / U:7.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site