lkml.org 
[lkml]   [2013]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH]tty:vt: Add NULL check to return value of kzalloc()
On Tue, Oct 29, 2013 at 12:26:05AM +0800, Wang YanQing wrote:
> In extreme situation kzalloc in con_init may
> return NULL, so we should check it to prevent
> OOPS!
>
> Signed-off-by: Wang YanQing <udknight@gmail.com>
> Reported-by: rucsoftsec@gmail.com

I need a name for Reported-by: as well, not just an email.

> ---
> I don't think a system without memory to initialize
> vt could do some useful things, but this patch could
> make debug easier and improve kernel code's robustness
> in theory.

Please always run your patches through the scripts/checkpatch.pl tool
and fix the problems found there so that maintainers don't have to point
out the same thing...

greg k-h


\
 
 \ /
  Last update: 2013-10-28 18:21    [W:0.100 / U:0.844 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site