Messages in this thread | | | Date | Mon, 28 Oct 2013 09:04:09 -0700 | From | Laura Abbott <> | Subject | Re: [PATCH] mm: cma: free cma page to buddy instead of being cpu hot page |
| |
On 10/28/2013 4:42 AM, zhang.mingjun@linaro.org wrote: > From: Mingjun Zhang <troy.zhangmingjun@linaro.org> > > free_contig_range frees cma pages one by one and MIGRATE_CMA pages will be > used as MIGRATE_MOVEABLE pages in the pcp list, it causes unnecessary > migration action when these pages reused by CMA. > > Signed-off-by: Mingjun Zhang <troy.zhangmingjun@linaro.org> > --- > mm/page_alloc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 0ee638f..84b9d84 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1362,7 +1362,8 @@ void free_hot_cold_page(struct page *page, int cold) > * excessively into the page allocator > */ > if (migratetype >= MIGRATE_PCPTYPES) { > - if (unlikely(is_migrate_isolate(migratetype))) { > + if (unlikely(is_migrate_isolate(migratetype)) > + || is_migrate_cma(migratetype)) > free_one_page(zone, page, 0, migratetype); > goto out; > } >
I submitted something very similar a while ago http://marc.info/?l=linaro-mm-sig&m=137645764208287&w=2 . Has the opinion on this patch changed?
Thanks, Laura
-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
| |