lkml.org 
[lkml]   [2013]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.5 50/64] farsync: fix info leak in ioctl
    Date
    3.5.7.24 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: =?UTF-8?q?Salva=20Peir=C3=B3?= <speiro@ai2.upv.es>

    commit 96b340406724d87e4621284ebac5e059d67b2194 upstream.

    The fst_get_iface() code fails to initialize the two padding bytes of
    struct sync_serial_settings after the ->loopback member. Add an explicit
    memset(0) before filling the structure to avoid the info leak.

    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    drivers/net/wan/farsync.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/net/wan/farsync.c b/drivers/net/wan/farsync.c
    index 1a62318..3710427 100644
    --- a/drivers/net/wan/farsync.c
    +++ b/drivers/net/wan/farsync.c
    @@ -1972,6 +1972,7 @@ fst_get_iface(struct fst_card_info *card, struct fst_port_info *port,
    }

    i = port->index;
    + memset(&sync, 0, sizeof(sync));
    sync.clock_rate = FST_RDL(card, portConfig[i].lineSpeed);
    /* Lucky card and linux use same encoding here */
    sync.clock_type = FST_RDB(card, portConfig[i].internalClock) ==
    --
    1.8.3.2


    \
     
     \ /
      Last update: 2013-10-28 16:41    [W:3.156 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site