lkml.org 
[lkml]   [2013]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] arch: use ASM_NL instead of ';' for assembler new line character in the macro
On 10/28/2013 04:00 PM, Chen Gang wrote:
> For some toolchains, they use another character as newline in a macro
> (e.g. arc uses '`'), so for generic assembly code, need use ASM_NL (a
> macro) instead of ';' for it.
>
> Since "linux/export.h" are mainly used for exporting work, then our fix
> more likely belongs to "linux/linkage.h", and we need add the related
> checking in "linkage.h".
>
> Also need notice 80 columns wrap, and '\t' for each line.
>
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> arch/arc/include/asm/linkage.h | 2 +
> include/asm-generic/vmlinux.lds.h | 350 +++++++++++++++++++------------------
> include/linux/linkage.h | 19 +

Like Max said, please drop the linker script bits - they are OK - otherwise ARC
kernel won't have been building at all.

And you also need to fix kernel/modsign_certificate.S as part of same patchset as
that is where the problem started in first place.

-Vineet


\
 
 \ /
  Last update: 2013-10-28 15:21    [W:0.093 / U:4.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site