lkml.org 
[lkml]   [2013]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v5 2/3] Staging: zram: Fix variable dereferenced before check
    Date
    This patch fixes the following Smatch warning in zram_drv.c-
    drivers/staging/zram/zram_drv.c:899
    destroy_device() warn: variable dereferenced before check 'zram->disk' (see line 896)

    Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
    ---

    This revision fixes the following issues of the previous revision-
    Seperating patches into Bug fix and Smatch fix

    drivers/staging/zram/zram_drv.c | 9 +++------
    1 file changed, 3 insertions(+), 6 deletions(-)

    diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c
    index d640a8f..9027975 100644
    --- a/drivers/staging/zram/zram_drv.c
    +++ b/drivers/staging/zram/zram_drv.c
    @@ -898,13 +898,10 @@ static void destroy_device(struct zram *zram)
    sysfs_remove_group(&disk_to_dev(zram->disk)->kobj,
    &zram_disk_attr_group);

    - if (zram->disk) {
    - del_gendisk(zram->disk);
    - put_disk(zram->disk);
    - }
    + del_gendisk(zram->disk);
    + put_disk(zram->disk);

    - if (zram->queue)
    - blk_cleanup_queue(zram->queue);
    + blk_cleanup_queue(zram->queue);
    }

    static int __init zram_init(void)
    --
    1.7.9.5


    \
     
     \ /
      Last update: 2013-10-28 13:41    [W:4.725 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site