lkml.org 
[lkml]   [2013]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] x86: unify copy_from_user() size checking

* Jan Beulich <JBeulich@suse.com> wrote:

> >>> On 26.10.13 at 12:31, Ingo Molnar <mingo@kernel.org> wrote:
> > * Jan Beulich <JBeulich@suse.com> wrote:
> >> I'd like to point out though that with __compiletime_object_size()
> >> being restricted to gcc before 4.6, the whole construct is going to
> >> become more and more pointless going forward. I would question
> >> however that commit 2fb0815c9ee6b9ac50e15dd8360ec76d9fa46a2 ("gcc4:
> >> disable __compiletime_object_size for GCC 4.6+") was really necessary,
> >> and instead this should have been dealt with as is done here from the
> >> beginning.
> >
> > Can we now revert 2fb0815c9ee6?
>
> Afaict yes, but I certainly didn't test with all possible gcc
> versions. So minimally everyone involved in getting that change in
> would be good to be in agreement.

Mind submitting a patch? I can keep it pending until v3.14, that
should give time for compiler dependencies to be caught. Even if it
breaks anything it shouldn't be too hard to revert again ;-)

Thanks,

Ingo


\
 
 \ /
  Last update: 2013-10-28 12:01    [W:0.095 / U:4.832 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site