Messages in this thread | | | From | OGAWA Hirofumi <> | Subject | Re: [PATCH 1/5] fat: add i_disksize to represent uninitialized size | Date | Sun, 27 Oct 2013 22:38:38 +0900 |
| |
Namjae Jeon <linkinjeon@gmail.com> writes:
Code seems to be much became simpler.
> diff --git a/fs/fat/cache.c b/fs/fat/cache.c > index 91ad9e1..37572c2 100644 > --- a/fs/fat/cache.c > +++ b/fs/fat/cache.c > @@ -329,10 +329,10 @@ int fat_bmap(struct inode *inode, sector_t sector, sector_t *phys, > return 0; > > /* > - * ->mmu_private can access on only allocation path. > + * ->i_disksize can access on only allocation path. > * (caller must hold ->i_mutex) > */ > - last_block = (MSDOS_I(inode)->mmu_private + (blocksize - 1)) > + last_block = (MSDOS_I(inode)->i_disksize + (blocksize - 1)) > >> blocksize_bits; > if (sector >= last_block) > return 0;
Hm, bmap() ioctl returns between ->mmu_private and i_disksize? I'm not checking other FSes what does... -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
| |