Messages in this thread Patch in this message | | | Subject | Re: [PATCH 1/8] IB/cxgb4: Fix formatting of physical address | From | Joe Perches <> | Date | Sun, 27 Oct 2013 14:58:31 -0700 |
| |
On Sun, 2013-10-27 at 21:50 +0000, Ben Hutchings wrote: > Physical addresses may be wider than virtual addresses (e.g. on i386 > with PAE) and must not be formatted with %p.
%pa works. %pa also prefixes with 0x.
> diff --git a/drivers/infiniband/hw/cxgb4/device.c b/drivers/infiniband/hw/cxgb4/device.c [] > @@ -602,10 +602,10 @@ static int c4iw_rdev_open(struct c4iw_rdev *rdev) > rdev->lldi.vr->qp.size, > rdev->lldi.vr->cq.start, > rdev->lldi.vr->cq.size); > - PDBG("udb len 0x%x udb base %p db_reg %p gts_reg %p qpshift %lu " > + PDBG("udb len 0x%x udb base %llx db_reg %p gts_reg %p qpshift %lu " > "qpmask 0x%x cqshift %lu cqmask 0x%x\n", > (unsigned)pci_resource_len(rdev->lldi.pdev, 2), > - (void *)(unsigned long)pci_resource_start(rdev->lldi.pdev, 2), > + (u64)pci_resource_start(rdev->lldi.pdev, 2), > rdev->lldi.db_reg, > rdev->lldi.gts_reg, > rdev->qpshift, rdev->qpmask, > >
| |