lkml.org 
[lkml]   [2013]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 5/8] [SCSI] tgt: Pass pointers to virt_to_page(), not integers
    From
    Date
    Most architectures define virt_to_page() as a macro that casts its
    argument such that an argument of type unsigned long will be accepted
    without complaint. However, the proper type is void *, and passing
    unsigned long results in a warning on MIPS.

    Compile-tested only.

    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/scsi/scsi_tgt_if.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/scsi/scsi_tgt_if.c b/drivers/scsi/scsi_tgt_if.c
    index 6209110..7199753 100644
    --- a/drivers/scsi/scsi_tgt_if.c
    +++ b/drivers/scsi/scsi_tgt_if.c
    @@ -286,7 +286,7 @@ static int uspace_ring_map(struct vm_area_struct *vma, unsigned long addr,
    int i, err;

    for (i = 0; i < TGT_RING_PAGES; i++) {
    - struct page *page = virt_to_page(ring->tr_pages[i]);
    + struct page *page = virt_to_page((void *)ring->tr_pages[i]);
    err = vm_insert_page(vma, addr, page);
    if (err)
    return err;

    --
    Ben Hutchings
    If at first you don't succeed, you're doing about average.
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2013-10-27 23:01    [W:3.461 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site