lkml.org 
[lkml]   [2013]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [BUG 3.12.rc4] Oops: unable to handle kernel paging request during shutdown
From
On Fri, Oct 25, 2013 at 11:10 AM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> On Friday, October 25, 2013 11:51:40 AM Rafael J. Wysocki wrote:
>
> /* don't keep reloading if cpufreq_driver exists */
> if (cpufreq_get_current_driver())
> - return 0;
> + return -EEXIST;
>
> if (acpi_disabled)
> - return 0;
> + return -ENODEV;
>
> pr_debug("acpi_cpufreq_init\n");

I think:

- EBUSY is a better error return than EEXIST here/

- do the ENODEV case first, because claiming something is busy when
you couldn't have used it anyway is kind of stupid)

but yeah, this looks like the right thing. Let's make sure there
aren't any annoying error messages etc printed out as a result of
this, though.

Linus


\
 
 \ /
  Last update: 2013-10-25 12:21    [W:0.540 / U:0.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site