lkml.org 
[lkml]   [2013]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Xen-devel] [PATCH] xen/hvc-console: Make it work with HVM guests.
On Thu, Oct 24, 2013 at 05:43:54PM +0100, Ian Campbell wrote:
> On Thu, 2013-10-24 at 17:30 +0100, Julien Grall wrote:
>
> > I'm sure the solution "move xen call earlier" will come up in few mails,
> > so there was a discussion for swiotlb few weeks ago
> > (https://lkml.org/lkml/2013/8/29/609). And the final decision was to
> > avoid specific Xen call in arch_setup.
>
> It wasn't so much a hard reject as a preference based on the need
> presented at the time.
>
> Perhaps a generic DT driven mechanism to detect hypervisors, called
> early, would be more acceptable?
>
> > Stefano, Ian, any opinion?
>
> The ifdef approach is a bit ugly, but if the other option doesn't work
> out I suppose we can live with it.
>
> But stepping back how/why is this function called on x86 when not
> running under Xen? Wouldn't the use have to be using console=hvc or
> earlyprintk=xen or something -- which strikes me as user error... IOW
> can we not just nuke the check

It shouldn't - ever. On x86 it is called from the early PV bootup code.

I occasionaly use it when developing/debugging and as such want it working
in HVM even during early bootup.

>
> Ian.
>


\
 
 \ /
  Last update: 2013-10-25 22:01    [W:0.110 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site